[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 25 15:26:54 PDT 2024


================
@@ -86,6 +86,8 @@ DYNAMIC_TAG(RELRSZ, 35)  // Size of Relr relocation table.
 DYNAMIC_TAG(RELR, 36)    // Address of relocation table (Relr entries).
 DYNAMIC_TAG(RELRENT, 37) // Size of a Relr relocation entry.
 
+DYNAMIC_TAG(CREL,  38)   // CREL relocation table
+
----------------
dwblaikie wrote:

> I think we need to avoid generic numbers for dynamic tags/section types etc, except possibly generic numbers that are a long way from the "normal" range. 

+1.

I've tried to pushback on using any standard range before it's been standardized (eg: https://github.com/llvm/llvm-project/pull/91280#issuecomment-2099201183 https://github.com/llvm/llvm-project/pull/91280#issuecomment-2101019352 ) but I haven't looked through the change completely to see all the enumerations used and how they're reserved, whether they use an extension space or what the argument is for them not using one.

Perhaps someone could summarize this aspect of the patch?

https://github.com/llvm/llvm-project/pull/91280


More information about the cfe-commits mailing list