[clang] [clang-format] Add option to remove leading blank lines (PR #91221)

Mon Jun 24 21:08:51 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-debian-cpp20` running on `clang-debian-cpp20` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/108/builds/408

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
138.143 [553/17/5170] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/FileDistance.cpp.o
138.200 [552/17/5171] Linking CXX static library lib/libclangIncludeFixer.a
138.280 [551/17/5172] Linking CXX static library lib/libclangIncludeFixerPlugin.a
141.959 [550/17/5173] Building CXX object tools/clang/tools/extra/clang-change-namespace/CMakeFiles/obj.clangChangeNamespace.dir/ChangeNamespace.cpp.o
142.093 [549/17/5174] Linking CXX static library lib/libclangChangeNamespace.a
142.343 [548/17/5175] Linking CXX executable bin/clang-include-fixer
142.354 [547/17/5176] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/FS.cpp.o
142.378 [546/17/5177] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/FuzzyMatch.cpp.o
143.554 [545/17/5178] Building CXX object tools/clang/tools/extra/include-cleaner/tool/CMakeFiles/clang-include-cleaner.dir/IncludeCleaner.cpp.o
145.500 [544/17/5179] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o
FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o 
ccache /usr/bin/clang++-17 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/build/tools/clang/tools/extra/clangd -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/../include-cleaner/include -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/build/tools/clang/tools/extra/clangd/../clang-tidy -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang/include -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/build/tools/clang/include -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/build/include -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/llvm/include -I/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/pseudo/lib/../include -Wno-deprecated-enum-enum-conversion -Wno-deprecated-declarations -Wno-deprecated-anon-enum-enum-conversion -Wno-ambiguous-reversed-operator -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++20  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -MF tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o.d -o tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -c /vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/Format.cpp
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/Format.cpp:284:11: error: no member named 'KeepEmptyLinesAtTheStartOfBlocks' in 'clang::format::FormatStyle'
  284 |     Style.KeepEmptyLinesAtTheStartOfBlocks = true;
      |     ~~~~~ ^
1 error generated.
145.578 [544/16/5180] Linking CXX executable bin/clang-change-namespace
150.255 [544/15/5181] Building CXX object tools/clang/tools/extra/clang-move/CMakeFiles/obj.clangMove.dir/Move.cpp.o
150.359 [544/14/5182] Building CXX object tools/clang/tools/extra/tool-template/CMakeFiles/tool-template.dir/ToolTemplate.cpp.o
150.561 [544/13/5183] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ASTSignals.cpp.o
151.096 [544/12/5184] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CollectMacros.cpp.o
152.858 [544/11/5185] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/WalkAST.cpp.o
156.374 [544/10/5186] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/GlobalCompilationDatabase.cpp.o
157.388 [544/9/5187] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/FindSymbols.cpp.o
158.114 [544/8/5188] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Headers.cpp.o
159.484 [544/7/5189] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Diagnostics.cpp.o
161.077 [544/6/5190] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ClangdServer.cpp.o
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:860:52: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
  860 |                        CB(clangd::superTypes(Item, Index));
      |                                                    ^
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:859:23: note: add an explicit capture of 'this' to capture '*this' by reference
  859 |                      [=, CB = std::move(CB)]() mutable {
      |                       ^
      |                        , this
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:868:69: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
  868 |       [=, CB = std::move(CB)]() mutable { CB(clangd::subTypes(Item, Index)); });
      |                                                                     ^
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:868:8: note: add an explicit capture of 'this' to capture '*this' by reference
  868 |       [=, CB = std::move(CB)]() mutable { CB(clangd::subTypes(Item, Index)); });
      |        ^
      |         , this
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:876:64: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
  876 |         clangd::resolveTypeHierarchy(Item, Resolve, Direction, Index);
      |                                                                ^
/vol/worker/clang-debian-cpp20/clang-debian-cpp20/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:875:38: note: add an explicit capture of 'this' to capture '*this' by reference
  875 |       "Resolve Type Hierarchy", "", [=, CB = std::move(CB)]() mutable {
      |                                      ^
      |                                       , this
3 warnings generated.

```

https://github.com/llvm/llvm-project/pull/91221