[clang] [clang-format] Add option to remove leading blank lines (PR #91221)

Mon Jun 24 21:07:02 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64be-linux-multistage` running on `ppc64be-clang-multistage-test` while building `clang` at step 4 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/167/builds/241

Here is the relevant piece of the build log for the reference:
```
Step 4 (build stage 1) failure: 'ninja' (failure)
...
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clang-tidy/bugprone/../utils/../ClangTidyDiagnosticConsumer.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clang-tidy/bugprone/../utils/../ClangTidyCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clang-tidy/bugprone/../utils/TransformerClangTidyCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:9:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/llvm/include/llvm/ADT/SmallVector.h: In member function ‘void llvm::SmallVectorTemplateBase<T, <anonymous> >::grow(size_t) [with T = std::shared_ptr<clang::transformer::MatchComputation<std::basic_string<char> > >; bool <anonymous> = false]’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/llvm/include/llvm/ADT/SmallVector.h:446:6: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  446 | void SmallVectorTemplateBase<T, TriviallyCopyable>::grow(size_t MinSize) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[105/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o
FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o 
ccache /opt/rh/devtoolset-11/root/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/tools/clang/tools/extra/clangd -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/../include-cleaner/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/tools/clang/tools/extra/clangd/../clang-tidy -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/tools/clang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/llvm/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/pseudo/lib/../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -MF tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o.d -o tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/Format.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/Format.cpp: In function ‘std::vector<clang::tooling::Replacement> clang::clangd::formatIncremental(llvm::StringRef, unsigned int, llvm::StringRef, clang::format::FormatStyle)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/Format.cpp:284:11: error: ‘struct clang::format::FormatStyle’ has no member named ‘KeepEmptyLinesAtTheStartOfBlocks’
  284 |     Style.KeepEmptyLinesAtTheStartOfBlocks = true;
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[106/281] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/BugproneTidyModule.cpp.o
[107/281] Building CXX object tools/clang/tools/extra/tool-template/CMakeFiles/tool-template.dir/ToolTemplate.cpp.o
[108/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ASTSignals.cpp.o
[109/281] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/WalkAST.cpp.o
[110/281] Building CXX object tools/clang/tools/extra/clang-change-namespace/CMakeFiles/obj.clangChangeNamespace.dir/ChangeNamespace.cpp.o
[111/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CollectMacros.cpp.o
[112/281] Linking CXX executable bin/clang-include-fixer
[113/281] Linking CXX executable bin/clang-import-test
[114/281] Linking CXX executable bin/clang-extdef-mapping
[115/281] Building CXX object tools/clang/tools/extra/clang-move/CMakeFiles/obj.clangMove.dir/Move.cpp.o
[116/281] Linking CXX shared library lib/libLTO.so.19.0git
[117/281] Linking CXX executable bin/clang-rename
[118/281] Linking CXX executable bin/clang-refactor
[119/281] Linking CXX executable bin/llvm-lto
[120/281] Linking CXX executable bin/clang-linker-wrapper
[121/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/GlobalCompilationDatabase.cpp.o
[122/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Quality.cpp.o
[123/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/HeaderSourceSwitch.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/SourceCode.h:21,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/CollectMacros.h:13,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/ParsedAST.h:23,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/HeaderSourceSwitch.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/HeaderSourceSwitch.cpp:9:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/include/clang/Basic/LangOptions.h: In function ‘std::optional<std::basic_string<char> > clang::clangd::getCorrespondingHeaderOrSource(clang::clangd::PathRef, clang::clangd::ParsedAST&, const clang::clangd::SymbolIndex*)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang/include/clang/Basic/LangOptions.h:461:7: note: the layout of aggregates containing vectors with 2-byte alignment has changed in GCC 5
  461 | class LangOptions : public LangOptionsBase {
      |       ^~~~~~~~~~~
[124/281] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Diagnostics.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/llvm/include/llvm/Support/JSON.h:49,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/support/Trace.h:23,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/support/MemoryTree.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/Protocol.h:28,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/clang-tools-extra/clangd/Diagnostics.h:12,

```

https://github.com/llvm/llvm-project/pull/91221