[clang] [clang-format] Add option to remove leading blank lines (PR #91221)

Mon Jun 24 21:06:52 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64be-linux-test-suite` running on `ppc64be-clang-test-suite` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/176/builds/358

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/utils/../ClangTidyOptions.h:17,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/utils/../ClangTidyDiagnosticConsumer.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/utils/../ClangTidyCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:9:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h: In member function ‘void llvm::SmallVectorTemplateBase<T, <anonymous> >::grow(size_t) [with T = std::shared_ptr<clang::transformer::MatchComputation<std::basic_string<char> > >; bool <anonymous> = false]’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h:446:6: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  446 | void SmallVectorTemplateBase<T, TriviallyCopyable>::grow(size_t MinSize) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
58.646 [145/40/97] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o
FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o 
ccache /opt/rh/devtoolset-11/root/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/tools/clang/tools/extra/clangd -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/../include-cleaner/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/tools/clang/tools/extra/clangd/../clang-tidy -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/tools/clang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/pseudo/lib/../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -MF tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o.d -o tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Format.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/Format.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/Format.cpp: In function ‘std::vector<clang::tooling::Replacement> clang::clangd::formatIncremental(llvm::StringRef, unsigned int, llvm::StringRef, clang::format::FormatStyle)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/Format.cpp:284:11: error: ‘struct clang::format::FormatStyle’ has no member named ‘KeepEmptyLinesAtTheStartOfBlocks’
  284 |     Style.KeepEmptyLinesAtTheStartOfBlocks = true;
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
59.488 [145/39/98] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/IncludeCleanerCheck.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/misc/../../include-cleaner/include/clang-include-cleaner/Analysis.h:16,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:14:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/include/clang/Format/Format.h: In constructor ‘clang::format::FormatStyle::FormatStyle(clang::format::FormatStyle&&)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/include/clang/Format/Format.h:55:8: note: the layout of aggregates containing vectors with 2-byte alignment has changed in GCC 5
   55 | struct FormatStyle {
      |        ^~~~~~~~~~~
59.795 [145/38/99] Building CXX object tools/clang/lib/Tooling/Refactoring/CMakeFiles/obj.clangToolingRefactoring.dir/Rename/USRLocFinder.cpp.o
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp: In function ‘std::vector<clang::tooling::AtomicChange> clang::tooling::createRenameAtomicChanges(llvm::ArrayRef<std::basic_string<char> >, llvm::StringRef, clang::Decl*)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:529:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  529 | createRenameAtomicChanges(llvm::ArrayRef<std::string> USRs,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
60.298 [145/37/100] Building CXX object tools/clang/tools/extra/clang-tidy/abseil/CMakeFiles/obj.clangTidyAbseilModule.dir/StringFindStrContainsCheck.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/Support/VirtualFileSystem.h:19,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/abseil/../ClangTidyOptions.h:17,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/abseil/../ClangTidyDiagnosticConsumer.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/abseil/../ClangTidyCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h:12,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:9:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h: In member function ‘void llvm::SmallVectorTemplateBase<T, <anonymous> >::grow(size_t) [with T = std::shared_ptr<clang::transformer::MatchComputation<std::basic_string<char> > >; bool <anonymous> = false]’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h:446:6: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  446 | void SmallVectorTemplateBase<T, TriviallyCopyable>::grow(size_t MinSize) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
60.895 [145/36/101] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/BugproneTidyModule.cpp.o
61.019 [145/35/102] Building CXX object tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/AddUsing.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/SourceCode.h:21,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/Headers.h:13,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/AST.h:16,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:9:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/include/clang/Basic/LangOptions.h: In member function ‘virtual bool clang::clangd::{anonymous}::AddUsing::prepare(const clang::clangd::Tweak::Selection&)’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/clang/include/clang/Basic/LangOptions.h:461:7: note: the layout of aggregates containing vectors with 2-byte alignment has changed in GCC 5
  461 | class LangOptions : public LangOptionsBase {
      |       ^~~~~~~~~~~

```

https://github.com/llvm/llvm-project/pull/91221