[clang] [libclang/python] Refactor enum usage (PR #95608)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 24 02:11:38 PDT 2024


https://github.com/Endilll commented:

LGTM

> There is also TokenKind: this one does not currently inherit from BaseEnumeration and is defined somewhat differently, having all its variants and their IDs as a dictionary in enumerations.py. This seems quite arbitrary to me, is there any reason it is done this way? Otherwise I would also move this to cindex.py as another subclass of BaseEnumeration

I agree that this seems arbitrary. You think you can proceed with refactoring `TokenKind`.

https://github.com/llvm/llvm-project/pull/95608


More information about the cfe-commits mailing list