[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

LLVM Continuous Integration via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 22 03:13:56 PDT 2024


llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/459

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
[1410/1412] Linking CXX executable tools/clang/unittests/Tooling/ToolingTests
[1411/1412] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/wasm-ld
-- Testing: 20716 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60
FAIL: Clang :: Index/overriding-ftemplate-comments.cpp (13175 of 20716)
******************** TEST 'Clang :: Index/overriding-ftemplate-comments.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: rm -rf /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
+ rm -rf /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
RUN: at line 2: mkdir /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
+ mkdir /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
RUN: at line 3: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/c-index-test -test-load-source all -comments-xml-schema=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/../../bindings/xml/comment-xml-schema.rng /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp > /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp/out
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/c-index-test -test-load-source all -comments-xml-schema=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/../../bindings/xml/comment-xml-schema.rng /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp
RUN: at line 4: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp < /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp/out
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp:80:11: error: CHECK: expected string not found in input
// CHECK: FullCommentAsXML=[<Function templateKind="template" file="{{[^"]+}}overriding-ftemplate-comments.cpp" line="[[@LINE-2]]" column="6"><Name>comment_to_html_conversion_22</Name><USR>c:@FT@>2#T#t>2#T#t>2#T#Tcomment_to_html_conversion_22#v#</USR><Declaration>template <class C1, template <class C2, template <class C3, class C4> class BBB>\n class AAA>\nvoid comment_to_html_conversion_22()</Declaration><TemplateParameters><Parameter><Name>C1</Name><Index>0</Index><Discussion><Para> Ccc 1 </Para></Discussion></Parameter><Parameter><Name>AAA</Name><Index>1</Index><Discussion><Para> Zzz </Para></Discussion></Parameter><Parameter><Name>C2</Name><Discussion><Para> Ccc 2 </Para></Discussion></Parameter><Parameter><Name>C3</Name><Discussion><Para> Ccc 3 </Para></Discussion></Parameter><Parameter><Name>C4</Name><Discussion><Para> Ccc 4 </Para></Discussion></Parameter><Parameter><Name>BBB</Name><Discussion><Para> Bbb</Para></Discussion></Parameter></TemplateParameters></Function>]
          ^
<stdin>:604:1467: note: scanning from here
// CHECK: overriding-ftemplate-comments.cpp:65:6: FunctionTemplate=comment_to_html_conversion_21:65:6 RawComment=[/// \tparam AAA Aaa\n/// \tparam BBB Bbb\n/// \tparam CCC Ccc\n/// \tparam DDD Ddd] RawCommentRange=[55:1 - 58:20] FullCommentAsHTML=[<dl><dt class="tparam-name-index-0">PPP</dt><dd class="tparam-descr-index-0"> Aaa </dd><dt class="tparam-name-index-other">QQQ</dt><dd class="tparam-descr-index-other"> Bbb </dd><dt class="tparam-name-index-other">RRR</dt><dd class="tparam-descr-index-other"> Ccc </dd><dt class="tparam-name-index-other">SSS</dt><dd class="tparam-descr-index-other"> Ddd</dd></dl>] FullCommentAsXML=[<Function templateKind="template" file="/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp" line="65" column="6"><Name>comment_to_html_conversion_21</Name><USR>c:@FT@>1#t>2#t>1#T#Tcomment_to_html_conversion_21#v#</USR><Declaration>template <template <template <typename RRR> class SSS, class QQQ> class PPP>\nvoid comment_to_html_conversion_21()</Declaration><TemplateParameters><Parameter><Name>PPP</Name><Index>0</Index><Discussion><Para> Aaa </Para></Discussion></Parameter><Parameter><Name>QQQ</Name><Discussion><Para> Bbb </Para></Discussion></Parameter><Parameter><Name>RRR</Name><Discussion><Para> Ccc </Para></Discussion></Parameter><Parameter><Name>SSS</Name><Discussion><Para> Ddd</Para></Discussion></Parameter></TemplateParameters></Function>]
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^
<stdin>:604:1467: note: with "@LINE-2" equal to "78"
// CHECK: overriding-ftemplate-comments.cpp:65:6: FunctionTemplate=comment_to_html_conversion_21:65:6 RawComment=[/// \tparam AAA Aaa\n/// \tparam BBB Bbb\n/// \tparam CCC Ccc\n/// \tparam DDD Ddd] RawCommentRange=[55:1 - 58:20] FullCommentAsHTML=[<dl><dt class="tparam-name-index-0">PPP</dt><dd class="tparam-descr-index-0"> Aaa </dd><dt class="tparam-name-index-other">QQQ</dt><dd class="tparam-descr-index-other"> Bbb </dd><dt class="tparam-name-index-other">RRR</dt><dd class="tparam-descr-index-other"> Ccc </dd><dt class="tparam-name-index-other">SSS</dt><dd class="tparam-descr-index-other"> Ddd</dd></dl>] FullCommentAsXML=[<Function templateKind="template" file="/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp" line="65" column="6"><Name>comment_to_html_conversion_21</Name><USR>c:@FT@>1#t>2#t>1#T#Tcomment_to_html_conversion_21#v#</USR><Declaration>template <template <template <typename RRR> class SSS, class QQQ> class PPP>\nvoid comment_to_html_conversion_21()</Declaration><TemplateParameters><Parameter><Name>PPP</Name><Index>0</Index><Discussion><Para> Aaa </Para></Discussion></Parameter><Parameter><Name>QQQ</Name><Discussion><Para> Bbb </Para></Discussion></Parameter><Parameter><Name>RRR</Name><Discussion><Para> Ccc </Para></Discussion></Parameter><Parameter><Name>SSS</Name><Discussion><Para> Ddd</Para></Discussion></Parameter></TemplateParameters></Function>]
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
          599: // CHECK: (CXComment_Text Text=[ Ddd]))))] Extent=[59:1 - 60:37] 
          600: // CHECK: overriding-ftemplate-comments.cpp:59:70: TemplateTemplateParameter=AAA:59:70 (Definition) Extent=[59:10 - 59:73] [access=public] 
          601: // CHECK: overriding-ftemplate-comments.cpp:59:48: TemplateTemplateParameter=DDD:59:48 (Definition) Extent=[59:19 - 59:51] [access=public] 
          602: // CHECK: overriding-ftemplate-comments.cpp:59:37: TemplateTypeParameter=CCC:59:37 (Definition) Extent=[59:28 - 59:40] [access=public] 
          603: // CHECK: overriding-ftemplate-comments.cpp:59:59: TemplateTypeParameter=BBB:59:59 (Definition) Extent=[59:53 - 59:62] [access=public] 
Step 7 (check) failure: check (failure)
...
[1410/1412] Linking CXX executable tools/clang/unittests/Tooling/ToolingTests
[1411/1412] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/wasm-ld
-- Testing: 20716 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60
FAIL: Clang :: Index/overriding-ftemplate-comments.cpp (13175 of 20716)
******************** TEST 'Clang :: Index/overriding-ftemplate-comments.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: rm -rf /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
+ rm -rf /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
RUN: at line 2: mkdir /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
+ mkdir /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp
RUN: at line 3: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/c-index-test -test-load-source all -comments-xml-schema=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/../../bindings/xml/comment-xml-schema.rng /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp > /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp/out
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/c-index-test -test-load-source all -comments-xml-schema=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/../../bindings/xml/comment-xml-schema.rng /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp
RUN: at line 4: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp < /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/tools/clang/test/Index/Output/overriding-ftemplate-comments.cpp.tmp/out
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-jetnqeqt/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp:80:11: error: CHECK: expected string not found in input
// CHECK: FullCommentAsXML=[<Function templateKind="template" file="{{[^"]+}}overriding-ftemplate-comments.cpp" line="[[@LINE-2]]" column="6"><Name>comment_to_html_conversion_22</Name><USR>c:@FT@>2#T#t>2#T#t>2#T#Tcomment_to_html_conversion_22#v#</USR><Declaration>template <class C1, template <class C2, template <class C3, class C4> class BBB>\n class AAA>\nvoid comment_to_html_conversion_22()</Declaration><TemplateParameters><Parameter><Name>C1</Name><Index>0</Index><Discussion><Para> Ccc 1 </Para></Discussion></Parameter><Parameter><Name>AAA</Name><Index>1</Index><Discussion><Para> Zzz </Para></Discussion></Parameter><Parameter><Name>C2</Name><Discussion><Para> Ccc 2 </Para></Discussion></Parameter><Parameter><Name>C3</Name><Discussion><Para> Ccc 3 </Para></Discussion></Parameter><Parameter><Name>C4</Name><Discussion><Para> Ccc 4 </Para></Discussion></Parameter><Parameter><Name>BBB</Name><Discussion><Para> Bbb</Para></Discussion></Parameter></TemplateParameters></Function>]
          ^
<stdin>:604:1467: note: scanning from here
// CHECK: overriding-ftemplate-comments.cpp:65:6: FunctionTemplate=comment_to_html_conversion_21:65:6 RawComment=[/// \tparam AAA Aaa\n/// \tparam BBB Bbb\n/// \tparam CCC Ccc\n/// \tparam DDD Ddd] RawCommentRange=[55:1 - 58:20] FullCommentAsHTML=[<dl><dt class="tparam-name-index-0">PPP</dt><dd class="tparam-descr-index-0"> Aaa </dd><dt class="tparam-name-index-other">QQQ</dt><dd class="tparam-descr-index-other"> Bbb </dd><dt class="tparam-name-index-other">RRR</dt><dd class="tparam-descr-index-other"> Ccc </dd><dt class="tparam-name-index-other">SSS</dt><dd class="tparam-descr-index-other"> Ddd</dd></dl>] FullCommentAsXML=[<Function templateKind="template" file="/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp" line="65" column="6"><Name>comment_to_html_conversion_21</Name><USR>c:@FT@>1#t>2#t>1#T#Tcomment_to_html_conversion_21#v#</USR><Declaration>template <template <template <typename RRR> class SSS, class QQQ> class PPP>\nvoid comment_to_html_conversion_21()</Declaration><TemplateParameters><Parameter><Name>PPP</Name><Index>0</Index><Discussion><Para> Aaa </Para></Discussion></Parameter><Parameter><Name>QQQ</Name><Discussion><Para> Bbb </Para></Discussion></Parameter><Parameter><Name>RRR</Name><Discussion><Para> Ccc </Para></Discussion></Parameter><Parameter><Name>SSS</Name><Discussion><Para> Ddd</Para></Discussion></Parameter></TemplateParameters></Function>]
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^
<stdin>:604:1467: note: with "@LINE-2" equal to "78"
// CHECK: overriding-ftemplate-comments.cpp:65:6: FunctionTemplate=comment_to_html_conversion_21:65:6 RawComment=[/// \tparam AAA Aaa\n/// \tparam BBB Bbb\n/// \tparam CCC Ccc\n/// \tparam DDD Ddd] RawCommentRange=[55:1 - 58:20] FullCommentAsHTML=[<dl><dt class="tparam-name-index-0">PPP</dt><dd class="tparam-descr-index-0"> Aaa </dd><dt class="tparam-name-index-other">QQQ</dt><dd class="tparam-descr-index-other"> Bbb </dd><dt class="tparam-name-index-other">RRR</dt><dd class="tparam-descr-index-other"> Ccc </dd><dt class="tparam-name-index-other">SSS</dt><dd class="tparam-descr-index-other"> Ddd</dd></dl>] FullCommentAsXML=[<Function templateKind="template" file="/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp" line="65" column="6"><Name>comment_to_html_conversion_21</Name><USR>c:@FT@>1#t>2#t>1#T#Tcomment_to_html_conversion_21#v#</USR><Declaration>template <template <template <typename RRR> class SSS, class QQQ> class PPP>\nvoid comment_to_html_conversion_21()</Declaration><TemplateParameters><Parameter><Name>PPP</Name><Index>0</Index><Discussion><Para> Aaa </Para></Discussion></Parameter><Parameter><Name>QQQ</Name><Discussion><Para> Bbb </Para></Discussion></Parameter><Parameter><Name>RRR</Name><Discussion><Para> Ccc </Para></Discussion></Parameter><Parameter><Name>SSS</Name><Discussion><Para> Ddd</Para></Discussion></Parameter></TemplateParameters></Function>]
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/Index/overriding-ftemplate-comments.cpp

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
          599: // CHECK: (CXComment_Text Text=[ Ddd]))))] Extent=[59:1 - 60:37] 
          600: // CHECK: overriding-ftemplate-comments.cpp:59:70: TemplateTemplateParameter=AAA:59:70 (Definition) Extent=[59:10 - 59:73] [access=public] 
          601: // CHECK: overriding-ftemplate-comments.cpp:59:48: TemplateTemplateParameter=DDD:59:48 (Definition) Extent=[59:19 - 59:51] [access=public] 
          602: // CHECK: overriding-ftemplate-comments.cpp:59:37: TemplateTypeParameter=CCC:59:37 (Definition) Extent=[59:28 - 59:40] [access=public] 
          603: // CHECK: overriding-ftemplate-comments.cpp:59:59: TemplateTypeParameter=BBB:59:59 (Definition) Extent=[59:53 - 59:62] [access=public] 

```

https://github.com/llvm/llvm-project/pull/95025


More information about the cfe-commits mailing list