[clang] [ParserHLSL] Attempt to parse HLSL annotations on Field Decls. (PR #96346)

Damyan Pepper via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 21 13:05:08 PDT 2024


================
@@ -2646,6 +2646,9 @@ bool Parser::ParseCXXMemberDeclaratorBeforeInitializer(
   else
     DeclaratorInfo.SetIdentifier(nullptr, Tok.getLocation());
 
+  if (getLangOpts().HLSL)
----------------
damyanp wrote:

I'm not proposing we combine them.  My observation is that one of them will do the right thing if you call it outside of HLSL mode and the other one will do the wrong thing.  So, if you were to switch from using one overload to another you may find that you've introduce a surprising bug.

https://github.com/llvm/llvm-project/pull/96346


More information about the cfe-commits mailing list