[clang] [NFC] Fix dead links in TargetCXXABI.def (PR #96348)

Mital Ashok via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 21 12:24:16 PDT 2024


https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/96348

>From 702bae96f10c903d60b98430e13f57c5bb227849 Mon Sep 17 00:00:00 2001
From: Mital Ashok <mital at mitalashok.co.uk>
Date: Fri, 21 Jun 2024 19:36:01 +0100
Subject: [PATCH 1/2] [NFC] Fix dead links in TargetCXXABI.def

---
 clang/include/clang/Basic/TargetCXXABI.def | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/clang/include/clang/Basic/TargetCXXABI.def b/clang/include/clang/Basic/TargetCXXABI.def
index 9501cca760945..c1de583cd4974 100644
--- a/clang/include/clang/Basic/TargetCXXABI.def
+++ b/clang/include/clang/Basic/TargetCXXABI.def
@@ -29,7 +29,7 @@
 /// many compilers, including Clang and GCC.
 ///
 /// It is documented here:
-///   http://www.codesourcery.com/public/cxx-abi/
+///   http://itanium-cxx-abi.github.io/cxx-abi/
 ITANIUM_CXXABI(GenericItanium, "itanium")
 
 /// The generic ARM ABI is a modified version of the Itanium ABI
@@ -46,8 +46,7 @@ ITANIUM_CXXABI(GenericItanium, "itanium")
 ///   - and more!
 ///
 /// It is documented here:
-///    http://infocenter.arm.com
-///                    /help/topic/com.arm.doc.ihi0041c/IHI0041C_cppabi.pdf
+///    https://github.com/ARM-software/abi-aa
 ITANIUM_CXXABI(GenericARM, "arm")
 
 /// The iOS ABI is a partial implementation of the ARM ABI.
@@ -65,8 +64,7 @@ ITANIUM_CXXABI(iOS, "ios")
 /// ABI more closely, but we don't guarantee to follow it perfectly.
 ///
 /// It is documented here:
-///    http://infocenter.arm.com
-///                  /help/topic/com.arm.doc.ihi0059a/IHI0059A_cppabi64.pdf
+///    https://github.com/ARM-software/abi-aa
 ITANIUM_CXXABI(AppleARM64, "applearm64")
 
 /// WatchOS is a modernisation of the iOS ABI, which roughly means it's

>From 8dd746dfcc63f013e26047fd4fc39ac0d637d71e Mon Sep 17 00:00:00 2001
From: Mital Ashok <mital at mitalashok.co.uk>
Date: Fri, 21 Jun 2024 20:24:04 +0100
Subject: [PATCH 2/2] Link to 64-bit and 32-bit Arm ABI specifically; Move link
 64-bit Arm link to GenericAArch64 doc instead of AppleARM64

---
 clang/include/clang/Basic/TargetCXXABI.def | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clang/include/clang/Basic/TargetCXXABI.def b/clang/include/clang/Basic/TargetCXXABI.def
index c1de583cd4974..447297b688ef5 100644
--- a/clang/include/clang/Basic/TargetCXXABI.def
+++ b/clang/include/clang/Basic/TargetCXXABI.def
@@ -46,7 +46,7 @@ ITANIUM_CXXABI(GenericItanium, "itanium")
 ///   - and more!
 ///
 /// It is documented here:
-///    https://github.com/ARM-software/abi-aa
+///    https://github.com/ARM-software/abi-aa/blob/main/cppabi32/cppabi32.rst
 ITANIUM_CXXABI(GenericARM, "arm")
 
 /// The iOS ABI is a partial implementation of the ARM ABI.
@@ -62,9 +62,6 @@ ITANIUM_CXXABI(iOS, "ios")
 
 /// The iOS 64-bit and macOS 64-bit ARM ABI follows ARM's published 64-bit
 /// ABI more closely, but we don't guarantee to follow it perfectly.
-///
-/// It is documented here:
-///    https://github.com/ARM-software/abi-aa
 ITANIUM_CXXABI(AppleARM64, "applearm64")
 
 /// WatchOS is a modernisation of the iOS ABI, which roughly means it's
@@ -78,6 +75,9 @@ ITANIUM_CXXABI(WatchOS, "watchos")
 /// The relevant changes from the generic ABI in this case are:
 ///   - representation of member function pointers adjusted as in ARM.
 ///   - guard variables  are smaller.
+///
+/// It is documented here:
+///    https://github.com/ARM-software/abi-aa/blob/main/cppabi64/cppabi64.rst
 ITANIUM_CXXABI(GenericAArch64, "aarch64")
 
 /// The generic Mips ABI is a modified version of the Itanium ABI.



More information about the cfe-commits mailing list