[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

[Cory Fields via cfe-commits]

theuni wrote:

I tried out this WIP on our codebase after we ran into a problem where an annotation was added to a definition rather than a declaration, leading to a (silently) missed capability check.

This addition seems to work fine, but it triggers warnings when annotations are added to both the definition and declaration. This can be seen here: https://github.com/bitcoin/bitcoin/pull/30316

I went ahead and PR'd the removals because they're straightforward enough, but it seems (to me) that those these are all false positives. If the same annotation is listed in the declaration and definition, should it really warn?

https://github.com/llvm/llvm-project/pull/67520