[clang] [Clang] Remove preprocessor guards and global feature checks for NEON (PR #95224)
Maciej Gabka via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 20 09:26:20 PDT 2024
================
@@ -8086,23 +8086,21 @@ static void HandleNeonVectorTypeAttr(QualType &CurType, const ParsedAttr &Attr,
// Target must have NEON (or MVE, whose vectors are similar enough
// not to need a separate attribute)
- if (!(S.Context.getTargetInfo().hasFeature("neon") ||
- S.Context.getTargetInfo().hasFeature("mve") ||
- S.Context.getTargetInfo().hasFeature("sve") ||
- S.Context.getTargetInfo().hasFeature("sme") ||
+ if (!(S.Context.getTargetInfo().hasFeature("mve") ||
IsTargetCUDAAndHostARM) &&
----------------
mgabka wrote:
I am suggesting that in that patch we removed error emission when targeting GPU, since now we are restricting error emission to M class processors, I think the extra handling for GPUS can be removed.
https://github.com/llvm/llvm-project/pull/95224
More information about the cfe-commits
mailing list