[clang] 021b9d0 - [Sema] Use llvm::erase_if (NFC) (#96068)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 19 07:52:59 PDT 2024
Author: Kazu Hirata
Date: 2024-06-19T07:52:54-07:00
New Revision: 021b9d0239f830244ebe0deb77cdca8fceeb6613
URL: https://github.com/llvm/llvm-project/commit/021b9d0239f830244ebe0deb77cdca8fceeb6613
DIFF: https://github.com/llvm/llvm-project/commit/021b9d0239f830244ebe0deb77cdca8fceeb6613.diff
LOG: [Sema] Use llvm::erase_if (NFC) (#96068)
While I am at it, I'm constructing SmallVector directly from ArrayRef.
Added:
Modified:
clang/lib/Sema/SemaOpenACC.cpp
Removed:
################################################################################
diff --git a/clang/lib/Sema/SemaOpenACC.cpp b/clang/lib/Sema/SemaOpenACC.cpp
index 97586a037eee4..cf207be33175c 100644
--- a/clang/lib/Sema/SemaOpenACC.cpp
+++ b/clang/lib/Sema/SemaOpenACC.cpp
@@ -841,14 +841,10 @@ OpenACCClause *SemaOpenACCClauseVisitor::VisitAttachClause(
// ActOnVar ensured that everything is a valid variable reference, but we
// still have to make sure it is a pointer type.
- llvm::SmallVector<Expr *> VarList{Clause.getVarList().begin(),
- Clause.getVarList().end()};
- VarList.erase(std::remove_if(VarList.begin(), VarList.end(),
- [&](Expr *E) {
- return SemaRef.CheckVarIsPointerType(
- OpenACCClauseKind::Attach, E);
- }),
- VarList.end());
+ llvm::SmallVector<Expr *> VarList{Clause.getVarList()};
+ llvm::erase_if(VarList, [&](Expr *E) {
+ return SemaRef.CheckVarIsPointerType(OpenACCClauseKind::Attach, E);
+ });
Clause.setVarListDetails(VarList,
/*IsReadOnly=*/false, /*IsZero=*/false);
return OpenACCAttachClause::Create(Ctx, Clause.getBeginLoc(),
@@ -866,14 +862,10 @@ OpenACCClause *SemaOpenACCClauseVisitor::VisitDevicePtrClause(
// ActOnVar ensured that everything is a valid variable reference, but we
// still have to make sure it is a pointer type.
- llvm::SmallVector<Expr *> VarList{Clause.getVarList().begin(),
- Clause.getVarList().end()};
- VarList.erase(std::remove_if(VarList.begin(), VarList.end(),
- [&](Expr *E) {
- return SemaRef.CheckVarIsPointerType(
- OpenACCClauseKind::DevicePtr, E);
- }),
- VarList.end());
+ llvm::SmallVector<Expr *> VarList{Clause.getVarList()};
+ llvm::erase_if(VarList, [&](Expr *E) {
+ return SemaRef.CheckVarIsPointerType(OpenACCClauseKind::DevicePtr, E);
+ });
Clause.setVarListDetails(VarList,
/*IsReadOnly=*/false, /*IsZero=*/false);
More information about the cfe-commits
mailing list