[clang-tools-extra] [clangd] Support go-to-definition on type hints. The core part (PR #86629)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 18 21:11:29 PDT 2024


================
@@ -174,6 +175,29 @@ SourceLocation nameLocation(const clang::Decl &D, const SourceManager &SM) {
   return SM.getExpansionLoc(L);
 }
 
+// Expects Loc to be a SpellingLocation, will bail out otherwise as it can't
----------------
HighCommander4 wrote:

nit: please move the comment to the declaration, since it's describing a requirement of the function's interface

https://github.com/llvm/llvm-project/pull/86629


More information about the cfe-commits mailing list