[clang] [llvm] [analyzer][NFC] Reorganize Z3 report refutation (PR #95128)
Mikael Holmén via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 18 05:42:02 PDT 2024
mikaelholmen wrote:
> > I don't know really, I just noticed that main suddenly broke for us and bisected to this patch.
>
> If after the second patch the tests pass then I'm contemplated to say I'd go for upgrading Z3 requirements to 4.8.9, and accept that with my first commit would have failed the CI/tests with an old(er) Z3. On my system, all `StaticAnalysisTests` pass with 4.8.9 on `main`. Are you okay with upgrading Z3 to at least 4.8.9 or preferably to latest (4.13.0)?
The testcases fail botth on this and on the next patch. I just commented here because this is the first patch there are problems.
I have to check with my team why we are on 4.8.8 and what we can upgrade to. In any case that won't happen today.
But I'm surprised that requirements were suddenly raised without warning.
https://github.com/llvm/llvm-project/pull/95128
More information about the cfe-commits
mailing list