https://github.com/AaronBallman commented: The changes seem pretty reasonable to me (aside from a few small nits), but I'd appreciate someone with more compiler-rt knowledge to also sign off on the changes. https://github.com/llvm/llvm-project/pull/93612