[clang] [llvm] Cleanup MC/DC intrinsics for #82448 (PR #95496)
NAKAMURA Takumi via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 17 03:33:37 PDT 2024
chapuni wrote:
@zmodem #82448 doesn't use intermediate condbitmap but integer index. I decided not to modify and use the intrinsic `condbitmapupdate`, since the signature will be quite different and this is too simple to be put into the intrinsic.
Also pre-#82448 impl of `condbitmapupdate` was so simple (`|= (V << ID)`) just to update the local variable. I wondered why it was implemented with the intrinsic.
In contrast, I modified `tvbitmapupdate` in #82448 without getting rid of it. I modified its signature and semantics. I thought `tvbitmapupdate` might be left as an intrinsic since it could be enhanced to atomic ops (and continuous bias mode).
I guess they would hit apparently buggy behavior if they were using obsolete `condbitmapupdate` and modified `tvbitmapupdate`.
Since I didn't update and won't update the semantics of `condupdate`, they should get rid of it, as far as they follow our trunk. I don't think I could provide "easy" migration path.
https://github.com/llvm/llvm-project/pull/95496
More information about the cfe-commits
mailing list