[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

[via cfe-commits]

================
@@ -171,21 +187,3 @@ void f() {
 #endif
 }
 } // namespace discarded_member_access
-
-
-// cxx11-warning at 5 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 9 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 12 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 13 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 29 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 65 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 67 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 71 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 73 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 74 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 84 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 86 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 87 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 91 {{use of the 'nodiscard' attribute is a C++17 extension}}
-// cxx11-warning at 92 {{use of the 'nodiscard' attribute is a C++20 extension}}
-// cxx11-warning at 95 {{use of the 'nodiscard' attribute is a C++20 extension}}
----------------
Sirraide wrote:

I will say, this was very confusing to me just now. Are there any actual changes left in this file at this point? This refactoring here is nice, but it should be part of a separate NFC patch if there are no other changes in this file...

https://github.com/llvm/llvm-project/pull/95112