[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

Paul Kirth via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 14 14:58:05 PDT 2024


================
@@ -49,6 +49,8 @@
 using namespace clang::ast_matchers;
 using namespace clang::tooling;
 using namespace clang;
+using DirIterator = llvm::sys::fs::directory_iterator;
----------------
ilovepi wrote:

There is a` DirIterator` in LLVM's VFS, and it is confusing to see you reuse that name. Normally iterators are written `It` in LLVM. ``DirIt` is probably a better name. I don't think it needs to be at file scope either, since its basically used in 1 place. you can add the using statement w/in the function that needs it, since its just for clarification.

If you really want it at files scope, stop at `using llvm::sys::fs`

https://github.com/llvm/llvm-project/pull/94717


More information about the cfe-commits mailing list