[clang] [llvm] [llvm][Support] Stop using PWD in current_path (PR #94544)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 13 10:08:31 PDT 2024


=?utf-8?q?IƱaki?= Amatria Barral <inaki.amatria at appentra.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/94544 at github.com>


================
@@ -17,10 +17,6 @@
 // GCNO-LOCATION: "-coverage-notes-file={{.*}}/foo/bar.gcno"
 // GCNO-LOCATION-REL: "-coverage-notes-file={{.*}}{{/|\\\\}}foo/bar.gcno"
 
-/// GCC allows PWD to change the paths.
-// RUN: %if system-linux %{ PWD=/proc/self/cwd %clang -### -c --coverage %s -o foo/bar.o 2>&1 | FileCheck --check-prefix=PWD %s %}
-// PWD: "-coverage-notes-file=/proc/self/cwd/foo/bar.gcno" "-coverage-data-file=/proc/self/cwd/foo/bar.gcda"
----------------
AaronBallman wrote:

Sure! Basically, you'd write a post in https://discourse.llvm.org/ with a title along the lines of `[RFC]; stop using PWD in current_path` and some explanation of what you'd like to change, why, and what the impacts are. Folks will leave comments in the post about things you should also consider, and eventually discussion dies down and we (hopefully) have clear direction on what to do from there.

I would recommend posting this RFC in the [Clang category](https://discourse.llvm.org/c/clang/6) though it's possible the changes could impact other projects.

https://github.com/llvm/llvm-project/pull/94544


More information about the cfe-commits mailing list