[clang] [Clang][AMDGPU] Add a builtin for llvm.amdgcn.make.buffer.rsrc intrinsic (PR #95276)

Shilei Tian via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 12 13:47:25 PDT 2024


shiltian wrote:

> I am wondering whether prefix the builtin type with `__amdgcn_` would be better since I envision risk of conflicting with reserved names of other compilers or standard libraries.

In the patch where the type was introduced we had a brief back-and-forth. I checked the reference type WASM introduced and they don't have prefix. I don't think in the future we'd have a cross-platform/-compiler type called `__buffer_rsrc_t`, and it happens, it is not supposed to have `__` prefix. However, I'm by no means a language expert, so I'm fine if we really want to add that.

https://github.com/llvm/llvm-project/pull/95276


More information about the cfe-commits mailing list