[clang-tools-extra] 1c59362 - [clangd] Make it possible to enable misc-const-correctness clang-tidy check (#94920)

[via cfe-commits]

Author: geza-herman
Date: 2024-06-11T13:32:12-04:00
New Revision: 1c59362e4456fb0861fcf4be9831b4db3e921b2b

URL: https://github.com/llvm/llvm-project/commit/1c59362e4456fb0861fcf4be9831b4db3e921b2b
DIFF: https://github.com/llvm/llvm-project/commit/1c59362e4456fb0861fcf4be9831b4db3e921b2b.diff

LOG: [clangd] Make it possible to enable misc-const-correctness clang-tidy check (#94920)

Before this PR, clangd forcefully disabled misc-const-correctness in
disableUnusableChecks().

Now we have a FastCheckFilter configuration whose default value
(Strict) also disables it. This patch removes misc-const-correctness
from disableUnusableChecks() so it's possible to enable by setting
FastCheckFilter to None.

Fixes https://github.com/llvm/llvm-project/issues/89758

Added: 
    

Modified: 
    clang-tools-extra/clangd/TidyProvider.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/TidyProvider.cpp b/clang-tools-extra/clangd/TidyProvider.cpp
index b658a80559937..a4121df30d3df 100644
--- a/clang-tools-extra/clangd/TidyProvider.cpp
+++ b/clang-tools-extra/clangd/TidyProvider.cpp
@@ -221,13 +221,7 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef<std::string> ExtraBadChecks) {
       "-hicpp-invalid-access-moved",
       // Check uses dataflow analysis, which might hang/crash unexpectedly on
       // incomplete code.
-      "-bugprone-unchecked-optional-access",
-
-      // ----- Performance problems -----
-
-      // This check runs expensive analysis for each variable.
-      // It has been observed to increase reparse time by 10x.
-      "-misc-const-correctness");
+      "-bugprone-unchecked-optional-access");
 
   size_t Size = BadChecks.size();
   for (const std::string &Str : ExtraBadChecks) {