[clang] [clang][ExtractAPI][NFC] pass params by const reference (PR #94820)

[Daniel Grumberg via cfe-commits]

================
@@ -199,7 +199,8 @@ class DeclarationFragments {
     return *this;
   }
 
-  DeclarationFragments &replace(std::string NewSpelling, unsigned Position) {
----------------
daniel-grumberg wrote:

I would prefer to keep the value semantics version and instead move assign the value, that way callers can move the string in and avoid any copies.

https://github.com/llvm/llvm-project/pull/94820