[clang] [clang-format] Fix bad comment indentation before ifdef after braceless if (PR #94776)

Owen Pan via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 8 12:13:31 PDT 2024


================
@@ -796,6 +796,44 @@ TEST_F(FormatTestComments, ParsesCommentsAdjacentToPPDirectives) {
             format("namespace {}\n   /* Test */    #define A"));
 }
 
+TEST_F(FormatTestComments, DeIdentsCommentBeforeIfdefAfterBracelessIf) {
+  verifyFormat("void f() {\n"
+               "  if (true)\n"
+               "    int i;\n"
+               "  /* comment */\n"
+               "#ifdef A\n"
+               "  int j;\n"
+               "#endif\n"
+               "}",
+               "void f() {\n"
+               "  if (true)\n"
+               "    int i;\n"
+               "    /* comment */\n"
+               "#ifdef A\n"
+               "  int j;\n"
+               "#endif\n"
+               "}");
+
+  verifyFormat("void f() {\n"
+               "  if (true)\n"
+               "    int i;\n"
+               "  /* comment */\n"
----------------
owenca wrote:

It doesn't look right as the comment is likely for the line above it.

https://github.com/llvm/llvm-project/pull/94776


More information about the cfe-commits mailing list