[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

[Paul Kirth via cfe-commits]

================
@@ -182,23 +231,12 @@ Example usage for a project using a compile commands database:
       {"index.js", "index_json.js"}};
 
   if (Format == "html") {
-    void *MainAddr = (void *)(intptr_t)GetExecutablePath;
-    std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr);
-    llvm::SmallString<128> NativeClangDocPath;
-    llvm::sys::path::native(ClangDocPath, NativeClangDocPath);
-    llvm::SmallString<128> AssetsPath;
-    AssetsPath = llvm::sys::path::parent_path(NativeClangDocPath);
-    llvm::sys::path::append(AssetsPath, "..", "share", "clang");
-    llvm::SmallString<128> DefaultStylesheet;
-    llvm::sys::path::native(AssetsPath, DefaultStylesheet);
-    llvm::sys::path::append(DefaultStylesheet,
-                            "clang-doc-default-stylesheet.css");
-    llvm::SmallString<128> IndexJS;
-    llvm::sys::path::native(AssetsPath, IndexJS);
-    llvm::sys::path::append(IndexJS, "index.js");
-    CDCtx.UserStylesheets.insert(CDCtx.UserStylesheets.begin(),
-                                 std::string(DefaultStylesheet));
-    CDCtx.FilesToCopy.emplace_back(IndexJS.str());
+    if (!UserAssetPath.empty() &&
+        llvm::sys::fs::is_directory(std::string(UserAssetPath))) {
+      GetAssetFiles(CDCtx);
----------------
ilovepi wrote:

I'm OK w/ the fallback like this, but we probably want to tell the user something about what's wrong with what they've provided. So, if `UserAssetPath` is empty, I wouldn't necessarily expect any diagnostic, though a logging message may be fine. However, in the case where the path is bad, I'd expect an error or some kind of printed diagnostic, telling the user that you're falling back to the default. There's a good rationale for both, so pick one you prefer, and write down the justification in the comments.

https://github.com/llvm/llvm-project/pull/94717