[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)

via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 07:59:01 PDT 2024


zmodem wrote:

> One function handles "functions" and the other "globals", so behaviour is not necessarily the same. However, if you feel it would be better that both use the same logic, then I will go ahead with adding this.

Yes, I think that since the dll attribute logic has been the same between GetOrCreateLLVMGlobal and GetOrCreateLLVMFunction so far, we should keep it the same until we find an explicit reason to make them different.

https://github.com/llvm/llvm-project/pull/94664


More information about the cfe-commits mailing list