[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)
Andrew Ng via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 7 04:37:29 PDT 2024
nga888 wrote:
> It would be nice to keep `GetOrCreateLLVMGlobal` and `GetOrCreateLLVMFunction` in sync. Would it be possible to extract the "Handle dropped DLL attributes" logic into a small utility function that could be called from both?
I did briefly think about this, but does this change really apply to `GetOrCreateLLVMGlobal`? Is there any test case to exercise it? Perhaps it would be better to leave `GetOrCreateLLVMGlobal` as is?
https://github.com/llvm/llvm-project/pull/94664
More information about the cfe-commits
mailing list