[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 6 08:36:49 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 3ac6a646d40cb16aebb3467007efa2e499383a3d c8467210ad82399482da5c9294d302e3695de288 -- clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/PreambleTests.cpp clang-tools-extra/clangd/unittests/XRefsTests.cpp clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/Tokens.cpp clang/unittests/Tooling/Syntax/TokensTest.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang-tools-extra/clangd/unittests/PreambleTests.cpp b/clang-tools-extra/clangd/unittests/PreambleTests.cpp
index 240d9bfc72..16a2f9448b 100644
--- a/clang-tools-extra/clangd/unittests/PreambleTests.cpp
+++ b/clang-tools-extra/clangd/unittests/PreambleTests.cpp
@@ -512,9 +512,10 @@ TEST(PreamblePatchTest, RefsToMacros) {
ExpectedLocations.push_back(referenceRangeIs(R));
for (const auto &P : Modified.points()) {
- auto *MacroTok = AST->getTokens().spelledTokenContaining(SM.getComposedLoc(
- SM.getMainFileID(),
- llvm::cantFail(positionToOffset(Modified.code(), P))));
+ auto *MacroTok =
+ AST->getTokens().spelledTokenContaining(SM.getComposedLoc(
+ SM.getMainFileID(),
+ llvm::cantFail(positionToOffset(Modified.code(), P))));
ASSERT_TRUE(MacroTok);
EXPECT_THAT(findReferences(*AST, P, 0).References,
testing::ElementsAreArray(ExpectedLocations));
``````````
</details>
https://github.com/llvm/llvm-project/pull/94528
More information about the cfe-commits
mailing list