[clang] [Clang][AArch64] Generalise streaming mode checks for builtins. (PR #93802)

Paul Walker via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 6 08:30:19 PDT 2024


================
@@ -622,7 +679,8 @@ bool SemaARM::CheckSMEBuiltinFunctionCall(unsigned BuiltinID,
     }
 
     if (BuiltinType)
-      checkArmStreamingBuiltin(SemaRef, TheCall, FD, *BuiltinType);
+      HasError |= checkArmStreamingBuiltin(SemaRef, TheCall, FD, *BuiltinType,
----------------
paulwalker-arm wrote:

Would it be wrong to return immediately? I ask because there's
```
  switch (BuiltinID) {
  default:
    return false;
```
which should be `return HasError;`? but if we can return directly then there's less change of other similar issues.

https://github.com/llvm/llvm-project/pull/93802


More information about the cfe-commits mailing list