[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

Sergio Afonso via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 5 04:11:57 PDT 2024


================
@@ -1698,6 +1701,64 @@ void OpenMPIRBuilder::createTaskyield(const LocationDescription &Loc) {
   emitTaskyieldImpl(Loc);
 }
 
+// Processes the dependencies in Dependencies and does the following
+// - Allocates space on the stack of an array of DependInfo objects
+// - Populates each DependInfo object with relevant information of
+//   the corresponding dependence.
+// - All code is inserted in the entry block of the current function.
+static Value *
+emitDepArray(OpenMPIRBuilder &OMPBuilder,
----------------
skatrak wrote:

```suggestion
emitTargetTaskDependenciesArray(OpenMPIRBuilder &OMPBuilder,
```
Nit: I think it's best to try avoiding arbitrary abbreviations in function names for readability. Perhaps the name I'm suggesting can be shortened if it's also intended for general tasks (`emitTaskDependenciesArray`), but it looks like it's only used for target tasks at the moment.

https://github.com/llvm/llvm-project/pull/93977


More information about the cfe-commits mailing list