[clang-tools-extra] [clang-tidy] `doesNotMutateObject`: Handle calls to member functions … (PR #94362)

Clement Courbet via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 5 00:47:32 PDT 2024


legrosbuffle wrote:

> Could this also be applied for https://github.com/llvm/llvm-project/issues/69577?

Weirdly, those two checks are using distinct methods to infer whether the underlying container is mutated. `unnecessary-copy-initialization` uses `doesNotMutateObject` while `performance-unnecessary-value-param` uses `FunctionParmMutationAnalyzer`.

So unfortunately this change won't improve `performance-unnecessary-value-param`.

I can have a look at unifying both in a subsequent PR.

https://github.com/llvm/llvm-project/pull/94362


More information about the cfe-commits mailing list