[clang] [clang-format] Allow open brace with trailing comment (no line break) (PR #89956)

Owen Pan via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 20:09:42 PDT 2024


owenca wrote:

> @owenca Re. draft status: I thought a draft would be a better way (less presumptuous, more tentative suggestion) to present one particular solution, while acknowledging the possibility of alternatives. If that's not really the way a draft is used or if it's more of a problem (e.g. people simply filtering out drafts for whatever reason?) then I can remove the draftness; I just didn't want to presume this change is the way to go.

My understanding is that draft pull requests are not ready for review, so I have always ignored them. From https://github.blog/2019-02-14-introducing-draft-pull-requests/:
> Also, if you have a [CODEOWNERS file](https://github.blog/2017-07-06-introducing-code-owners/) in your repository, a draft pull request will suppress notifications to those reviewers until it is marked as ready for review.

https://github.com/llvm/llvm-project/pull/89956


More information about the cfe-commits mailing list