[clang] clang/utils/TableGen/ClangOptionDocEmitter.cpp:220: Pointless string copy ? (#94373) (PR #94413)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: None (akshaykumars614)

<details>
<summary>Changes</summary>

modified parameter for code quality

---
Full diff: https://github.com/llvm/llvm-project/pull/94413.diff


1 Files Affected:

- (modified) clang/utils/TableGen/ClangOptionDocEmitter.cpp (+1-1) 


``````````diff
diff --git a/clang/utils/TableGen/ClangOptionDocEmitter.cpp b/clang/utils/TableGen/ClangOptionDocEmitter.cpp
index 86835611b8421..d0cb7f203c231 100644
--- a/clang/utils/TableGen/ClangOptionDocEmitter.cpp
+++ b/clang/utils/TableGen/ClangOptionDocEmitter.cpp
@@ -217,7 +217,7 @@ bool canSphinxCopeWithOption(const Record *Option) {
   return false;
 }
 
-void emitHeading(int Depth, std::string Heading, raw_ostream &OS) {
+void emitHeading(int Depth, const std::string &Heading, raw_ostream &OS) {
   assert(Depth < 8 && "groups nested too deeply");
   OS << Heading << '\n'
      << std::string(Heading.size(), "=~-_'+<>"[Depth]) << "\n";

``````````

</details>


https://github.com/llvm/llvm-project/pull/94413