[clang] clang/utils/TableGen/NeonEmitter.cpp:1058: pointless string copy ? (#94375) (PR #94408)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 16:04:27 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: None (akshaykumars614)

<details>
<summary>Changes</summary>


modified parameter for code quality

---
Full diff: https://github.com/llvm/llvm-project/pull/94408.diff


1 Files Affected:

- (modified) clang/utils/TableGen/NeonEmitter.cpp (+1-1) 


``````````diff
diff --git a/clang/utils/TableGen/NeonEmitter.cpp b/clang/utils/TableGen/NeonEmitter.cpp
index 56f1fdf9ef574..3f06e88c95ef5 100644
--- a/clang/utils/TableGen/NeonEmitter.cpp
+++ b/clang/utils/TableGen/NeonEmitter.cpp
@@ -1055,7 +1055,7 @@ std::string Intrinsic::getMangledName(bool ForceClassS) const {
   return mangleName(Name, ForceClassS ? ClassS : LocalCK);
 }
 
-std::string Intrinsic::mangleName(std::string Name, ClassKind LocalCK) const {
+std::string Intrinsic::mangleName( const std::string & Name, ClassKind LocalCK) const {
   std::string typeCode = getInstTypeCode(BaseType, LocalCK);
   std::string S = Name;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/94408


More information about the cfe-commits mailing list