[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 14:10:22 PDT 2024


adrian-prantl wrote:

> A revert is not appropriate when:
> lldb tests fail because AST printing has changed in Clang and the printed output is valid

Following the logic in this argument, would you also say it's appropriate for someone to commit an LLVM patch that changes how textual LLVM IR is printed in a way that it breaks existing tests in Clang — without updating those tests?

As far as I am concerned I would expect someone making such a change to at the very least update the Clang tests to the new format, but even better to have a discussion with the community whether the benefits of this change warrant the churn in the tests.

https://github.com/llvm/llvm-project/pull/94208


More information about the cfe-commits mailing list