[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 01:21:20 PDT 2024


pointhex wrote:

> Can you call `parseConfiguration()` instead of `getStyle()` in QtCreator while the user is entering code? It seems inefficient to call `getStyle()` all the time.

I do it in the places where I can use parseConfiguration instead. But in some cases I need getStyle and it's also called quite often. I have one optimisation in my mind, but I would like to have that patch as well anyway.

Am I right that no one has a major issue with the patch? So fixing the "const" issue and adding a unit test will let that in? 

https://github.com/llvm/llvm-project/pull/91317


More information about the cfe-commits mailing list