[clang] 68761a9 - [clang][nullability] Propagate storage location / value of `++`/`--` operators. (#94217)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 3 23:32:33 PDT 2024
Author: martinboehme
Date: 2024-06-04T08:32:29+02:00
New Revision: 68761a9e05693bd3986e46628e401c80a27e945d
URL: https://github.com/llvm/llvm-project/commit/68761a9e05693bd3986e46628e401c80a27e945d
DIFF: https://github.com/llvm/llvm-project/commit/68761a9e05693bd3986e46628e401c80a27e945d.diff
LOG: [clang][nullability] Propagate storage location / value of `++`/`--` operators. (#94217)
To avoid generating unnecessary values, we don't create a new value but
instead
leave it to the specific analysis to do this if desired.
Added:
Modified:
clang/lib/Analysis/FlowSensitive/Transfer.cpp
clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
Removed:
################################################################################
diff --git a/clang/lib/Analysis/FlowSensitive/Transfer.cpp b/clang/lib/Analysis/FlowSensitive/Transfer.cpp
index 4214488c98e5d..d161b231c0b6f 100644
--- a/clang/lib/Analysis/FlowSensitive/Transfer.cpp
+++ b/clang/lib/Analysis/FlowSensitive/Transfer.cpp
@@ -382,6 +382,20 @@ class TransferVisitor : public ConstStmtVisitor<TransferVisitor> {
Env.setValue(*S, Env.makeNot(*SubExprVal));
break;
}
+ case UO_PreInc:
+ case UO_PreDec:
+ // Propagate the storage location, but don't create a new value; to
+ // avoid generating unnecessary values, we leave it to the specific
+ // analysis to do this if desired.
+ propagateStorageLocation(*S->getSubExpr(), *S, Env);
+ break;
+ case UO_PostInc:
+ case UO_PostDec:
+ // Propagate the old value, but don't create a new value; to avoid
+ // generating unnecessary values, we leave it to the specific analysis
+ // to do this if desired.
+ propagateValue(*S->getSubExpr(), *S, Env);
+ break;
default:
break;
}
diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
index 5c0582e872eb0..cdaee9b2c9288 100644
--- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
@@ -3760,6 +3760,42 @@ TEST(TransferTest, AddrOfReference) {
});
}
+TEST(TransferTest, Preincrement) {
+ std::string Code = R"(
+ void target(int I) {
+ int &IRef = ++I;
+ // [[p]]
+ }
+ )";
+ runDataflow(
+ Code,
+ [](const llvm::StringMap<DataflowAnalysisState<NoopLattice>> &Results,
+ ASTContext &ASTCtx) {
+ const Environment &Env = getEnvironmentAtAnnotation(Results, "p");
+
+ EXPECT_EQ(&getLocForDecl(ASTCtx, Env, "IRef"),
+ &getLocForDecl(ASTCtx, Env, "I"));
+ });
+}
+
+TEST(TransferTest, Postincrement) {
+ std::string Code = R"(
+ void target(int I) {
+ int OldVal = I++;
+ // [[p]]
+ }
+ )";
+ runDataflow(
+ Code,
+ [](const llvm::StringMap<DataflowAnalysisState<NoopLattice>> &Results,
+ ASTContext &ASTCtx) {
+ const Environment &Env = getEnvironmentAtAnnotation(Results, "p");
+
+ EXPECT_EQ(&getValueForDecl(ASTCtx, Env, "OldVal"),
+ &getValueForDecl(ASTCtx, Env, "I"));
+ });
+}
+
TEST(TransferTest, CannotAnalyzeFunctionTemplate) {
std::string Code = R"(
template <typename T>
More information about the cfe-commits
mailing list