[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

Vladimir Vereschaka via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 14:21:43 PDT 2024


vvereschaka wrote:

>I think requiring all driver tests pass with a custom DEFAULT_SYSROOT is an undue burden.
>Do you know why llvm-zorg/buildbot/osuosl/master/config/builders.py llvm-clang-win-x-aarch64 needs to set DEFAULT_SYSROOT?
This is the arm toolchain builders. They build a whole toolchain including the libc++/libc++abi/libunwind libraries for the Arm targets. Also they build the library tests for the target ARM platform. All of those requires the target's sysroot (Arm/Aarch64 Ubuntu Linux in these cases) to build the executables. To avoid passing --sysroot through a bunch of CMake variables for the libraries and their tests the DEFAULT_SYSROOT cmake var was used (it was defined for that cases as far as I understood).


https://github.com/llvm/llvm-project/pull/94055


More information about the cfe-commits mailing list