[clang] [Driver] Fix the sysroot.c test properly (PR #94276)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 3 12:56:44 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Paul T Robinson (pogo59)
<details>
<summary>Changes</summary>
A DEFAULT_SYSROOT interfered with the test, apparently. See #<!-- -->95055.
---
Full diff: https://github.com/llvm/llvm-project/pull/94276.diff
1 Files Affected:
- (modified) clang/test/Driver/sysroot.c (+2-4)
``````````diff
diff --git a/clang/test/Driver/sysroot.c b/clang/test/Driver/sysroot.c
index 2215d6fa8fe73..85da2499090af 100644
--- a/clang/test/Driver/sysroot.c
+++ b/clang/test/Driver/sysroot.c
@@ -1,15 +1,13 @@
-// Fails on ARM/AArch64-hosted Windows, can't tell why.
-// UNSUPPORTED: system-windows
-
// Check that --sysroot= also applies to header search paths.
// RUN: %clang -target i386-unk-unk --sysroot=/FOO -### -E %s 2> %t1
// RUN: FileCheck --check-prefix=CHECK-SYSROOTEQ < %t1 %s
// CHECK-SYSROOTEQ: "-cc1"{{.*}} "-isysroot" "{{[^"]*}}/FOO"
// Apple Darwin uses -isysroot as the syslib root, too.
+// We pass --sysroot="" to defeat any -DDEFAULT_SYSROOT parameter.
// RUN: touch %t2.o
// RUN: %clang -target i386-apple-darwin10 \
-// RUN: -isysroot /FOO -### %t2.o 2> %t2
+// RUN: -isysroot /FOO --sysroot="" -### %t2.o 2> %t2
// RUN: FileCheck --check-prefix=CHECK-APPLE-ISYSROOT < %t2 %s
// CHECK-APPLE-ISYSROOT: "-arch" "i386"{{.*}} "-syslibroot" "{{[^"]*}}/FOO"
``````````
</details>
https://github.com/llvm/llvm-project/pull/94276
More information about the cfe-commits
mailing list