[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

Vladimir Vereschaka via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 11:52:52 PDT 2024


vvereschaka wrote:

@pogo59.

these two bots support *ONLY* ARM and Aarch64 targets (one target for the single bot). Also, this is the cross platform builders.
When you remove a requirement of the MIPS target for the mips's test it will get executed for the arm/aarch64 toolchain environment and most likely it will get failed. MIPS and ARM are the different targets, right? The same thing for the hecagon's tests. You need to apply the appropriate target requirements for the target depended tests to allow their execution on only in the proper environment.

>The best I can do is mark them UNSUPPORTED: system-windows to get the bots green again.

This is not a good idea. You will disable these tests for the appropriate cross builders for no reason and they will became useless for them. I would strongly recommend to revert #94253 and assign the correct target requirements for the failed tests (or restore the previous ones).
 

https://github.com/llvm/llvm-project/pull/94055


More information about the cfe-commits mailing list