[clang] [clang][deps] Collect discovered module dependencies' Link Libraries (PR #93588)

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 10:15:42 PDT 2024


================
@@ -138,6 +139,14 @@ struct ModuleDeps {
   /// determined that the differences are benign for this compilation.
   std::vector<ModuleID> ClangModuleDeps;
 
+  /// The set of libraries or frameworks to link against when
+  /// an entity from this module is used.
+  llvm::SmallVector<Module::LinkLibrary, 2> LinkLibraries;
+
+  /// Autolinking uses the framework name for linking purposes
+  /// when this is false and the export_as name otherwise.
+  bool UseExportAsModuleLinkName;
----------------
benlangmuir wrote:

How would this be used externally? We aren't providing export_as, nor identifying frameworks vs non-frameworks. Incidentally, you aren't exposing this in clang-scan-deps output as far as I can see.

If the idea is to drop the autolink of the current module, should we rework that so that we remove it from the link libraries of the importer instead?  It's a weird concept here since you have already resolved all the dependencies.

https://github.com/llvm/llvm-project/pull/93588


More information about the cfe-commits mailing list