[clang] [CUDA][HIP] Fix std::min in wrapper header (PR #93976)

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Fri May 31 10:37:48 PDT 2024


https://github.com/Artem-B approved this pull request.

LGTM for following the standard c++ library.

Floating point is an endless stream of surprises. 

E.g. https://pixorblog.wordpress.com/2016/06/27/some-remarks-about-minmax-functions/

> For instance, min() is not commutative and is not equivatent to cmath::fmin().



https://github.com/llvm/llvm-project/pull/93976


More information about the cfe-commits mailing list