[clang] [clang] Split up `SemaDeclAttr.cpp` (PR #93966)

Alexey Bader via cfe-commits cfe-commits at lists.llvm.org
Fri May 31 10:33:02 PDT 2024


================
@@ -14,9 +14,11 @@
 #define LLVM_CLANG_SEMA_SEMASYCL_H
 
 #include "clang/AST/Decl.h"
+#include "clang/AST/DeclBase.h"
----------------
bader wrote:

I'm okay with that.
It just looks strange to add forward declaration for `Decl` class when full declaration is included with `#include "clang/AST/Decl.h"`. Probably the cleaner solution would be to drop forward declaration of `Decl` and add it in the follow-up patch.
Anyway, this is a minor comment and should not block the merge.

https://github.com/llvm/llvm-project/pull/93966


More information about the cfe-commits mailing list