[clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu May 30 10:24:55 PDT 2024


rjmccall wrote:

I agree with Eli.  We should trust external record layout to the extent that it generates a valid layout, but if it generates something with overlapping fields, or that runs outside the claimed bounds of the type, we'll just end up crashing in IRGen.  I assume those things are expressible in DWARF; it'd take a bunch of sub-optimal representations to make them impossible.  It's probably clang's responsibility to detect that — maybe we ought to do a special sanity check on external layouts before we feed them into `RecordLayout`.

https://github.com/llvm/llvm-project/pull/93809


More information about the cfe-commits mailing list