[clang] [llvm] Split fmv and extensions (PR #92882)

Alexandros Lamprineas via cfe-commits cfe-commits at lists.llvm.org
Tue May 28 06:08:17 PDT 2024


================
@@ -1062,35 +1064,41 @@ bool AArch64TargetInfo::initFeatureMap(
     llvm::AArch64::getExtensionFeatures(Exts, CPUFeats);
----------------
labrinea wrote:

I am wondering if calling ExtensionSet::addCPUDefaults here would be preferable. It's not NFC. I saw a test failing because the attribute string for cortex-a710 would contain +v8.1a,+v8.2a,+v8.3a,+v8.4a,+v8.5a,+v8a,+v9a whereas before it didn't. That was `clang/test/CodeGen/aarch64-targetattr.c` for `__attribute__((target("cpu=cortex-a710")))`.

https://github.com/llvm/llvm-project/pull/92882


More information about the cfe-commits mailing list