[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Mon May 27 18:28:55 PDT 2024


================
@@ -159,7 +159,8 @@ class APINotesManager {
   ArrayRef<APINotesReader *> getCurrentModuleReaders() const {
     bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
     bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-    assert((!HasPrivate || HasPublic) && "private module requires public module");
+    assert((!HasPrivate || HasPublic) &&
+           "private module requires public module");
----------------
ChuanqiXu9 wrote:

Yes, we prefer to format the changed line only. Otherwise the backporting may be problematic. And git blaming will be harder.

One possible way maybe:

> git diff -U0 --no-color --relative HEAD^ | clang/tools/clang-format/clang-format-diff.py -p1 -i

https://github.com/llvm/llvm-project/pull/93417


More information about the cfe-commits mailing list