[clang] [clang][Interp] Member Pointers (PR #91303)

[via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/91303 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5c40db1da3a5ee1ed27b2ed874353dd80b294c15 19bb75633bf6875cecd0d6ec72e4d756c4b39174 -- clang/lib/AST/Interp/MemberPointer.cpp clang/lib/AST/Interp/MemberPointer.h clang/test/AST/Interp/memberpointers.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Disasm.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpStack.cpp clang/lib/AST/Interp/InterpStack.h clang/lib/AST/Interp/Pointer.cpp clang/lib/AST/Interp/Pointer.h clang/lib/AST/Interp/PrimType.cpp clang/lib/AST/Interp/PrimType.h clang/test/AST/Interp/eval-order.cpp clang/test/AST/Interp/literals.cpp clang/test/CodeGenCXX/mangle-ms-templates-memptrs.cpp clang/test/CodeGenCXX/pointers-to-data-members.cpp clang/test/SemaCXX/attr-weak.cpp clang/test/SemaCXX/nullptr_in_arithmetic_ops.cpp clang/unittests/AST/Interp/toAPValue.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
index 53e6b4cfc4..25c600efc2 100644
--- a/clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ b/clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -3349,7 +3349,7 @@ bool ByteCodeExprGen<Emitter>::VisitCallExpr(const CallExpr *E) {
       if (!this->emitGetMemberPtrBase(E))
         return false;
     } else if (!this->visit(MC->getImplicitObjectArgument())) {
-        return false;
+      return false;
     }
   }
 
diff --git a/clang/lib/AST/Interp/MemberPointer.h b/clang/lib/AST/Interp/MemberPointer.h
index d5299e0ff1..2eca911fc8 100644
--- a/clang/lib/AST/Interp/MemberPointer.h
+++ b/clang/lib/AST/Interp/MemberPointer.h
@@ -34,7 +34,8 @@ public:
   MemberPointer(uint32_t Address, const Descriptor *D) {
     // This should be impossible to hit, at least I've been unable
     // to write a test for it.
-    assert(false && "This constructor shouldn't be reachable for MemberPointers");
+    assert(false &&
+           "This constructor shouldn't be reachable for MemberPointers");
   }
 
   MemberPointer(const Decl *D) : Dcl(D) {
@@ -43,7 +44,9 @@ public:
   }
 
   uint64_t getIntegerRepresentation() const {
-    assert(false && "getIntegerRepresentation() shouldn't be reachable for MemberPointers");
+    assert(
+        false &&
+        "getIntegerRepresentation() shouldn't be reachable for MemberPointers");
     return 17;
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/91303