[clang-tools-extra] clang-doc switched from using relative to absolute paths (PR #93281)

Paul Kirth via cfe-commits cfe-commits at lists.llvm.org
Fri May 24 10:24:08 PDT 2024


================
@@ -1,48 +1,22 @@
-// Append using posix-style a file name or directory to Base
-function append(Base, New) {
-  if (!New)
-    return Base;
-  if (Base)
-    Base += "/";
-  Base += New;
-  return Base;
-}
-
-// Get relative path to access FilePath from CurrentDirectory
-function computeRelativePath(FilePath, CurrentDirectory) {
-  var Path = FilePath;
-  while (Path) {
-    if (CurrentDirectory == Path)
-      return FilePath.substring(Path.length + 1);
-    Path = Path.substring(0, Path.lastIndexOf("/"));
+function genLink(Ref) {
+  var Path = `${window.location.protocol}//${window.location.host}/${Ref.Path}`;
+  if (Ref.RefType !== "namespace") {
+    if (Ref.Path === "") {
+      Path = `${Path}${Ref.Name}.html`;
+    }
+    else {
+      Path = `${Path}/${Ref.Name}.html`;
+    }
----------------
ilovepi wrote:

I don't think this can be right, can it? The `if` and `else` have the same body. These branches used to retuern `index.html` or `${Path}${Ref.Name}.html`. Either the old behavior was correct, or this should be simplified to:

```suggestion
  if (Ref.RefType !== "namespace") {
      Path = `${Path}${Ref.Name}.html`;
```

https://github.com/llvm/llvm-project/pull/93281


More information about the cfe-commits mailing list