[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)

via cfe-commits cfe-commits at lists.llvm.org
Fri May 24 08:17:44 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 70a54bca6f7f9f45b4b17974ddaa01cd7a5d64be 5425cfb18b53f767fd9dc18e5ac7e196b5349f23 -- clang/test/CodeGenCXX/windows-instantiate-dllexport-template-specialization.cpp clang/lib/CodeGen/CodeGenModule.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index 6c3e7a6ffb..4327eeb92b 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -4856,8 +4856,7 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef MangledName, llvm::Type *Ty,
     if (D &&
         (Entry->getDLLStorageClass() ==
          llvm::GlobalVariable::DLLImportStorageClass) &&
-        !D->hasAttr<DLLImportAttr>() &&
-        !shouldMapVisibilityToDLLExport(D))
+        !D->hasAttr<DLLImportAttr>() && !shouldMapVisibilityToDLLExport(D))
       Entry->setDLLStorageClass(llvm::GlobalValue::DefaultStorageClass);
 
     if (LangOpts.OpenMP && !LangOpts.OpenMPSimd && D)

``````````

</details>


https://github.com/llvm/llvm-project/pull/93302


More information about the cfe-commits mailing list