[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 06:16:51 PDT 2024


================
@@ -12385,4 +12385,8 @@ def err_acc_reduction_composite_type
 def err_acc_reduction_composite_member_type :Error<
     "OpenACC 'reduction' composite variable must not have non-scalar field">;
 def note_acc_reduction_composite_member_loc : Note<"invalid field is here">;
+
+// AMDGCN builtins diagnostics
+def err_amdgcn_global_load_lds_size_invalid_value : Error<"invalid size value">;
+def note_amdgcn_global_load_lds_size_valid_value : Note<"size must be 1/2/4">;
----------------
arsenm wrote:

Not sure what the message phrasing guidelines are here, but probably should spill out 1, 2, or 4 rather than using / 

https://github.com/llvm/llvm-project/pull/93064


More information about the cfe-commits mailing list