[clang] [clang-tools-extra] [libcxx] Reland "[clang] Enable sized deallocation by default in C++14 onwards" (PR #90373)
Pengcheng Wang via cfe-commits
cfe-commits at lists.llvm.org
Wed May 22 23:30:09 PDT 2024
wangpc-pp wrote:
> > Based on my rough understanding, this is expected?
>
> What do you mean?
>
> Isn't this test needs to be updated or disabled?
I think this ASAN failure is not caused by this PR because these memorys are allocated/deallocated by `memory_resource` directly, **there is nothing about `new`/`delete`**. We allocate 50 bytes via `void* ret = r1.allocate(50);` and deallocate 1 byte via `r1.deallocate(ret, 1);` and that's the reason why ASAN failed, because the size of the allocated type (50 bytes) and the size of the deallocated type (1 byte) are really not matched.
I don't know if this is what we want to test, if so, we may add `// UNSUPPORTED: asan` to skip this test in ASAN builds.
cc @ldionne @Quuxplusone
https://github.com/llvm/llvm-project/pull/90373
More information about the cfe-commits
mailing list