[clang] [clang-repl] Extend the C support. (PR #89804)
Vassil Vassilev via cfe-commits
cfe-commits at lists.llvm.org
Wed May 22 22:53:21 PDT 2024
vgvassilev wrote:
> Just found out this keeps popping up from my notification, and I would like give my 2 cents, maybe can provide some insights:
>
> Looking at the backtrace of the failing tests, I noticed we ran into `clang::Parser::ParseTopLevelStmtDecl()` which makes me very confused. Do we actually enable the incremental extension in lldb? I grep it in lldb codebase and the only occurrence is here
>
> https://github.com/llvm/llvm-project/blob/b91b8fea8c58e9b414e291df677b12ca44197784/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp#L662
Hm, ok. I remember some discussions revolving around this but got the impression lldb turns that off. I think having it on is the right thing to do but that explains why my workaround did not work.
>
> The other thing I noticed is that the failure looks like have something to do with the objc, can we also check the current language we're compiling when skipping removing the name for the lexical scope?
I am hoping to cover objc, too. That's why I am really interested in figuring out what is going on. Otherwise if we limit the feature to c/c++ maybe we will get away with the bot. I still want to see why it crashes though...
https://github.com/llvm/llvm-project/pull/89804
More information about the cfe-commits
mailing list